search

ukdtom / WebTools.bundle

WebTools is a collection of tools for Plex Media Server. Like the Unsupported AppStore (UAS)
https://forums.plex.tv/discussion/288191
Mozilla Public License 2.0
1.3k stars 170 forks source link

Subs and paging #391

Closed ukdtom closed 6 years ago

ukdtom commented 7 years ago

Just so we don't forget this ;)

trumpy81 commented 7 years ago

Currently, if you expand library and search, then collapse that library, the search term cannot be cleared. We could use a clear search button as well. :)

creoludifico commented 7 years ago

Paging has been added to the sub module in the latest commit. Please check it out.

Btw @ukdtom you do not support searching and letter paging. api/v3/pms/getSection/key/4/start/0/size/20/getSubs/title/testsearchstring/letterKey/B Letter paging "B" will override the search "testsearchstring" and therefore return all the content in B not filtered by search.

I see two possible solutions. 1) We disable the search for all sections that has choosen a letter to filter from. We then tell the user that searching for the specific section is disabled while paging with letters. (Will be shown at the section) 2) You make the API support both searching and letter paging. This requires that 'getSectionLetterList' also gets updated so it will return a new size of each letter and whenever the letter shall be visible again.

ukdtom commented 7 years ago

4 now, let's go with option 1, and postpone the API change to maybe 3.1, since I have enough on my plate for now

ukdtom commented 7 years ago

And paging works perfectly ;)

creoludifico commented 7 years ago

I'll make solution 1 for now.

For solution 2 refering to #400

creoludifico commented 6 years ago

Lets go :-) r4t

ukdtom commented 6 years ago

Get more stopped working :(

ukdtom commented 6 years ago

Disregard....

Working perfectly