search

ukdtom / WebTools.bundle

WebTools is a collection of tools for Plex Media Server. Like the Unsupported AppStore (UAS)
https://forums.plex.tv/discussion/288191
Mozilla Public License 2.0
1.3k stars 170 forks source link

idx codec in subs #397

Closed ukdtom closed 6 years ago

ukdtom commented 7 years ago

If a movie has a sub, and it's codec is "idx", we show an option to view it.

This is wrong, since we only should not allow viewing of that type of codec, since we can't produce a propper output

ukdtom commented 7 years ago

Only supported codecs are: srt and subrip

/T

OttoKerner commented 7 years ago

Consider displaying any type of text-based subtitle. If Plex understands it, then you should too. Even ASS/SSA subs should be possible - even if they contain a lot of formatting instructions, but they are still basically text files.

ukdtom commented 7 years ago

True, and I stand corrected here regarding ASS/SSA

ukdtom commented 6 years ago

As well as VTT ;)

creoludifico commented 6 years ago

Lets go :-) r4t

ukdtom commented 6 years ago

Care to test @OttoKerner ?

OttoKerner commented 6 years ago

It doesn't look like it allows viewing of .smi or .ass subtitles

subs_look

ukdtom commented 6 years ago

@creoludifico Back to you, and sorry....

And to test, simply take a text file, and name it with moviename.<ext to test> Then refresh PMS

creoludifico commented 6 years ago

smi and ass added

ukdtom commented 6 years ago

@OttoKerner ?

ukdtom commented 6 years ago

And disregards @OttoKerner

Tested, and found sadly a bug, caused by PMS trying to be smart here....

When an ass file is detected, it get's reported as ssa.....SIGH...

ukdtom commented 6 years ago

Ref: https://www.matroska.org/technical/specs/subtitles/ssa.html

ukdtom commented 6 years ago

And tested, works fine now, so closing here