v3 Subtitles - Error when attempting to check subtitles

ukdtom / WebTools.bundle

WebTools is a collection of tools for Plex Media Server. Like the Unsupported AppStore (UAS)

https://forums.plex.tv/discussion/288191

Mozilla Public License 2.0

1.3k stars 170 forks source link

v3 Subtitles - Error when attempting to check subtitles #442

Closed trumpy81 closed 6 years ago

trumpy81 commented 6 years ago

Environment

PMS Platform(s) OS: Windows 10
PMS Version: 1.10.1.4527 (Get Loud Integration)
Name of Browser: FireFox 57.0.1

Error shown

Symptom: Attempt to check for subtitles in Other Video and Movie type libraries, an error message pops up. Does not effect TV Show type libraries. Hide media without subtitles option is unchecked.

Steps to reproduce

Attempt to check for subtitles

Expected behaviour

Files within a library be listed.

Actual behaviour

Error message is shown. See attached image.

Additional Info

Latest translation build (downloaded this morning 10:30am AEST 3-Dec-2017).

Checklist

[x] Listed environment
[x] Included PMS log zip and WebTools log
[x] Included screenshots (where appropriate)
[x] Checked that this isn't already an issue

untitled-1

WebTools logs: PMS Plugin Logs.zip

ukdtom commented 6 years ago

@trumpy81

You found a bug here ;)

Log says:

2017-12-03 10:40:18,878 (3b14) : CRITICAL (core:574) - Fatal error happened in getSection 'NoneType' object has no attribute 'lower' (most recent call last): File "C:\Users\ivatr\AppData\Local\Plex Media Server\Plug-ins\WebTools.bundle\Contents\Code\pmsV3.py", line 841, in GETSECTION if Dict['HideWithoutSubs'].lower() == 'true': AttributeError: 'NoneType' object has no attribute 'lower'

Thanks for reporting this, and will look into this ASAP

ukdtom commented 6 years ago

Please re-download and apply translate build Then close if fixed

trumpy81 commented 6 years ago

Downloaded and installed.

When selecting a library to search for subtitles I no longer get an error message, but if I enable 'Hide Media Without Subs' then it will show the spinning gear and never stop.

If I uncheck the 'Hide Media Without Subs' it will display all files, but the spinning gear is still shown at the end of the list instead of the Load More button. Only way to stop the spinning gear is to close the window and then re-open, sign in etc...

I assume this is because no subtitles are found in my library?

untitled-1

PS: Don't forget the updated themes ... lol ;)

ukdtom commented 6 years ago

That part is work in progress ;)

See https://github.com/ukdtom/WebTools.bundle/issues/439

ukdtom commented 6 years ago

And since you now can access and scan subs, I take it the initial bug you reported is fixed, so closing this one.

Do reopen if not