WT 3 - Logs listing shows non-text files

[JamminR]

Environment

• PMS Platform(s) OS: Windows 10
• PMS Version: 1.11.2.something
• Name of Browser: Firefox Quantum 58.0.2

  Error shown

  Technical Info: Url: api/v3/logs/show/FMoviePlus_tinkering.zip Location: Logs Error: logsService.getLogDetails - Fatal error happened in Logs show: [Errno 2] No such file or directory: u'D:\PlexCache\Plex Media Server\Logs\FMoviePlus_tinkering.zip'

• Symptom: Binary/zipped files located in Plex Logs directory attempt to load, and due to not being text, cause error indicating file is missing.

  Steps to reproduce

  1. Zip any single or series of logs using any common compression utility, store the file in the Plex server logs folder

Expected behaviour

1. Item not to appear in listing at best, or not attempt to open, or at least, display message "not a text" or "unreadable" - the file quite clearly exists.

Actual behaviour

1. Both a .zip file (Fmovies_plus.zip) and a .7z file (PMS Logs.7z) appear at the top, and are automatically selected and attempt to open when selecting the WT3 Logs menu.

Additional Info

2018-03-15 19:16:52,858 (2750) : DEBUG (logkit:13) - Recieved an apiV3 call for module: LOGS for method: GET 2018-03-15 19:16:52,858 (2750) : DEBUG (logkit:13) - Log Root dir is: D:\PlexCache\Plex Media Server\Logs 2018-03-15 19:16:52,858 (2750) : DEBUG (logkit:13) - Function to call is: SHOW with params: ['FMoviePlus_tinkering.zip'] 2018-03-15 19:16:52,858 (2750) : DEBUG (logkit:13) - Log Root dir is: D:\PlexCache\Plex Media Server\Logs 2018-03-15 19:16:52,858 (2750) : DEBUG (logkit:13) - Opening logfile: D:\PlexCache\Plex Media Server\Logs\FMoviePlus_tinkering.zip 2018-03-15 19:16:52,858 (2750) : CRITICAL (core:574) - Fatal error happened in Logs show: [Errno 2] No such file or directory: u'D:\PlexCache\Plex Media Server\Logs\FMoviePlus_tinkering.zip' (most recent call last): File "D:\PlexCache\Plex Media Server\Plug-ins\WebTools.bundle\Contents\Code\logsV3.py", line 307, in SHOW with io.open(file, 'r', errors='ignore') as content_file: IOError: [Errno 2] No such file or directory: u'D:\PlexCache\Plex Media Server\Logs\FMoviePlus_tinkering.zip'

2018-03-15 19:16:52,898 (2750) : DEBUG (logkit:13) - Recieved an apiV3 call for module: LOGS for method: PUT 2018-03-15 19:16:52,898 (2750) : DEBUG (logkit:13) - Log Root dir is: D:\PlexCache\Plex Media Server\Logs 2018-03-15 19:16:52,898 (2750) : DEBUG (logkit:13) - Function to call is: ENTRY with params: None 2018-03-15 19:16:52,898 (2750) : DEBUG (logkit:13) - Starting Logs.entry function 2018-03-15 19:16:52,900 (2750) : DEBUG (logkit:13) - FrontEnd: Location: Logs
Error: logsService.getLogDetails - Fatal error happened in Logs show: [Errno 2] No such file or directory: u'D:\PlexCache\Plex Media Server\Logs\FMoviePlus_tinkering.zip' 2018-03-15 19:17:32,405 (2750) : DEBUG (logkit:13) - Recieved an apiV3 call for module: LOGS for method: GET 2018-03-15 19:17:32,407 (2750) : DEBUG (logkit:13) - Log Root dir is: D:\PlexCache\Plex Media Server\Logs

Checklist

• [x] Listed environment
• [x] Included PMS log zip and WebTools log (THIS IS MANDATORY!)
• [ ] Included screenshots (where appropriate)
• [x] Checked that this isn't already an issue

[JamminR]

Bonus points for opening the zip and reading text files in it!!👍

[ukdtom]

That is not going to happen 4 sure, but I'll look into ignoring invalid files in the log directory

[ukdtom]

Fixed by adding a filter, only allowing file ext. as .log or .[integer]