build(deps): Unpin `faraday` from v1, upgrade to v2

uken / fluent-plugin-elasticsearch

Apache License 2.0

891 stars 310 forks source link

build(deps): Unpin `faraday` from v1, upgrade to v2 #1012

Closed raytung closed 1 year ago

raytung commented 1 year ago

DESCRIPTION HERE

(check all that apply)

[ ] tests added
[x] tests passing
[ ] README updated (if needed)
[ ] README Table of Contents updated (if needed)
[x] History.md and version in gemspec are untouched
[x] backward compatible
[ ] feature works in elasticsearch_dynamic (not required but recommended)

raytung commented 1 year ago

Thanks @cosmo0920 for helping out on this issue - I believe this is a confluent of issues, and there's a bug with Faraday and its adaptor in Ruby 2.7 (which I've jotted down in the linked issue). I don't think we could drop Ruby 2.7 support at the moment since the latest official Fluentd docker image is running on Ruby 2.7. Interested to hear your thoughts on this one.

cosmo0920 commented 1 year ago

From the official Fluentd docker image, we already moved to use Ruby 3.1 instead of 2.7. The left things are still using docker official image that is using Ruby 2.7: https://github.com/docker-library/official-images/blob/381271cfcf579d69b2a1410594e2926f865d38df/library/fluentd#L6 which is based on https://github.com/fluent/fluentd-docker-image/commit/a9e4cee765c7aaf7876d6fe3282aa565dbcdc2a4.

raytung commented 1 year ago

@cosmo0920 ah yes of course, I must be blind. Sounds like this fix should work (if all the tests pass). Thanks for your help!

cosmo0920 commented 1 year ago

Then, CI should be green. Here we go! 🚀

cosmo0920 commented 1 year ago

@kenhys @ashie Could you release the new version of this plugin if needed? Not in a hurry.

ashie commented 1 year ago

I see, thanks!

cosmo0920 commented 1 year ago

FYI: Docker library image of Fluentd is now updated to use v1.16.0 and Ruby 2.7 images are completely gone! https://github.com/docker-library/official-images/pull/14393