Fix support for host/hosts placeholders for ipv6 addresses

uken / fluent-plugin-elasticsearch

Apache License 2.0

891 stars 310 forks source link

Fix support for host/hosts placeholders for ipv6 addresses #1030

Closed Clee2691 closed 10 months ago

Clee2691 commented 11 months ago

This PR fixes support for host/hosts placeholders specifically for ipv6 addresses. Before this fix, IPv6 addresses would not be parsed correctly after evaluating host/hosts for placeholders.

(check all that apply)

[x] tests added
[x] tests passing
[ ] README updated (if needed)
[ ] README Table of Contents updated (if needed)
[x] History.md and version in gemspec are untouched
[ ] backward compatible
[ ] feature works in elasticsearch_dynamic (not required but recommended)

Clee2691 commented 11 months ago

@cosmo0920 can I get a review of this PR? cc @jcantrill

Clee2691 commented 11 months ago

@cosmo0920 Any progress on this?

cosmo0920 commented 10 months ago

Hi, sorry for long delayed reviewing. I resolved test failures. Now, I'm waiting for CI results.

cosmo0920 commented 10 months ago

Released this change as v5.4.0. Thank you for your contribution! :tada: