search

uken / newrelic-timing

Integrates Single Page Apps with NewRelic's Real User Monitoring
Apache License 2.0
99 stars 17 forks source link

Improve documentation #9

Closed PW999 closed 8 years ago

PW999 commented 9 years ago

Pull request with changes to allow grouping URL's with pathvariables and additional documentation to help configuring newrelic-timing, as per #8

pitr commented 9 years ago

tests are failing because of indentation issue, plz fix. Otherwise :+1: +1, thanks @PW999

/cc @dterror

dterror-zz commented 9 years ago

looks good +1 pending indentation

PW999 commented 9 years ago

That is odd, tests ran fine on my computer. Replaced a tab with spaces, hope travis build works fine now.

PW999 commented 9 years ago

Second build is now failing due to a missing dependency issue:

npm ERR! Error: No compatible version found: minimatch@'^2.0.1'

Can this pull request be merged or is there something else I have to change or alter ?

pitr commented 9 years ago

I'd say it's safe to merge. Seems like a problem with one of travis workers /cc @dterror

rpocklin commented 8 years ago

What's the status of this?

pitr commented 8 years ago

looks good, thanks @rpocklin for a bump