search

ukf / ukf-mda

UK federation aggregator beans
0 stars 2 forks source link

Purge Eclipse files from the repository #26

Closed iay closed 2 years ago

iay commented 2 years ago

For historical reasons related to how the Shibboleth project used to do things, this repository includes .project and .classpath files, plus a .settings directory representing Eclipse's idea that it is an Eclipse Java project.

Keeping these around causes problems if you use a different version of Eclipse or some other tool (such as Visual Studio Code) that shares state files.

The correct approach is for those files to be ignored by Git. This means adding them to .gitignore but also removing them explicitly using git rm. This is the approach the Shibboleth project now takes to this issue, and I would like to replicate it here.

This will remove them from clones. If those clones are used by people in Eclipse, they will need to be re-imported as Eclipse projects, giving them a new .project file which may or may not be similar to the old one. However, because of the .gitignore entry, that new file will not be suggested as a change to be re-committed.

philsmart commented 2 years ago

Those should be purged for the two branches in the PRs. I tested an import back into Eclipse. The new project files etc. are created and ignored correctly by Git.