ukgovdatascience / govdown

GOV.UK Design System theme for R Markdown
https://ukgovdatascience.github.io/govdown/
Other
46 stars 5 forks source link

Pass through args to base_format to make compatible with shiny #33

Closed RobinL closed 5 years ago

RobinL commented 5 years ago

This makes govdown compatible with being served on a Shiny Server (i.e. dynamically rendered).

It should close #32

I think since it's a simple arg pass through it doesn't break anything - but let me know if something more nuanced is needed.

Do you want me to increment the version number in DESCRIPTION? Does it go to 9001 from 9000?

nacnudus commented 5 years ago

Thanks for this. Yes, please could you increment the version. It goes up from 9000 to 9001, then 9002 etc. There are some Design System upgrades to pull in too, then it can have a release.

Please could you also document ...?