New Transport rendering

ukgovdatascience / govdown

GOV.UK Design System theme for R Markdown

https://ukgovdatascience.github.io/govdown/

Other

46 stars 5 forks source link

New Transport rendering #38

Closed mattkerlogue closed 5 years ago

mattkerlogue commented 5 years ago

Docs with font: "sans-serif" are rendering pages with New Transport.

---
output:
  govdown::govdown_document:
    font: "sans-serif" 
---

# Test

Results in:

Screen Shot 2019-09-18 at 13 00 23

See also govdown main page despite _site.yml specifying sans-serif.

Screen Shot 2019-09-18 at 13 03 02

mattkerlogue commented 5 years ago

Just looked at the page source for the test doc and govdown index, they both include references to “GDS Transport” in style blocks. So could either use readLines and scan for a reference to that, or use rvest to inspect it. Looked through the source for my mapping page (rendered in older version) and has no such references.

Could use this as a means for running a testing script.

nacnudus commented 5 years ago

Unfortunately even a test that scanned the html for references to the font wouldn't have detected this regression, because they renamed the font.