Details not display summary label - Githubissues

ukgovdatascience / govdown

GOV.UK Design System theme for R Markdown

https://ukgovdatascience.github.io/govdown/

Other

46 stars 5 forks source link

Details not display summary label #40

Closed mattkerlogue closed 5 years ago

mattkerlogue commented 5 years ago

When I create a details block the summary label doesn't appear. Compare this Rmd with the html.

From a brief scan, I think line 45 of govuk.lua might not be right and that it should be calling i.attributes rather than el.attributes

pandoc.utils.stringify(el.attributes["summary"]) ..

nacnudus commented 5 years ago

I can't reproduce the problem.

Has the html been rendered off that version of the Rmd? It has bullet points that aren't in the Rmd.

nacnudus commented 5 years ago

Confirmed. Also on android chrome, where it can't even be opened.

nacnudus commented 5 years ago

Only confirmed on the Travis build. Maybe it's a bug in pandoc.utils.stringify() that has been fixed since version 2.2.1, which is what the default Travis distro seems to use, going by the log:

curl -fLo /tmp/pandoc-2.2-1-amd64.deb https://github.com/jgm/pandoc/releases/download/2.2/pandoc-2.2-1-amd64.deb

nacnudus commented 5 years ago

Well this has been fun. v2.7 works, and so do v2.6 and v2.5. Now what?

Require v2.5? But it seems to be hard enough for people to get v2.0.
Document the "details" component? People will only see that if they refer to the docs when writing their own page, but not when they inherit a page from someone else.
Write my own stringify :weary:

@mattkerlogue as the main user, are you able to install pandoc v2.5+?

nacnudus commented 5 years ago

Writing my own stringify to support old versions of Pandoc looks like a pain and isn't justified at the moment. Users are welcome to ask for it if they need it though.