ukhsa-collaboration / COVID-19-app-iOS-BETA

Source code of the Beta of the NHS COVID-19 iOS app
https://covid19.nhs.uk/
MIT License
803 stars 179 forks source link

Validation of backgrounded service behaviour 'in the wild'...? #7

Closed jimsmart closed 4 years ago

jimsmart commented 4 years ago

With reference to the discussion in issue #2, I have some questions:

In reality, on iOS, backgrounded services can often be killed if one launches other apps that require a lot of RAM, e.g. games, or even visiting big webpages.

I am curious to know how the effectiveness of the app's backgrounded services is monitored, if at all, outside of 'laboratory'/test conditions?

Are there any built-in (opt-in) diagnostic analytics to monitor whether this is actually working as expected/intended in real-life / in the wild, under regular users' normal usage patterns?

Or is this understanding of backgrounded services' behaviour based solely upon on observations made during test conditions?

"To measure is to know"

Thanks.

jdmwood commented 4 years ago

Related to this, I'm surprised that the app is using Bluetooth peripheral mode instead of iBeacon (presumably to get around background running issues in iOS). Peripherals aren't really designed for this kind of constant scanning, discovery, ranging behaviour - they were intended to allow devices to discover, communicate and exchange data.

While it may appear that things "kind of" work, there may be side effects such as:

lukeredpath commented 4 years ago

Using iBeacon wouldn’t work for two reasons:

sanvean commented 4 years ago

Would also be curious to know how well they've actually stress tested the limits of the Apple + Android Bluetooth frameworks by putting several hundred devices in one room. If a subsequent device enters the room is it reliably discovered by all devices?

stephenheron commented 4 years ago

Yeah I would agree with this, given the extensive discussions and testing taking place in #2. It would be extremely useful to have access to the test data that the developers have.

There have been small scale tests and currently larger tests in progress. It would be useful to have access to the testing methodology and any results from these tests.

edent commented 4 years ago

I'm pasting this message in every active GitHub issue, so you may receive duplicate notifications.

Today, I'm happy to announce that NHSX has released the full git commit history for the Isle of Wight Beta apps.

As discussed, we have redacted API keys, sensitive domain names, and some of the developers' personal details. I am still waiting on final approval to publish the server-side code.

I would like to personally thank the community for your comments, bug reports, and vulnerability disclosures. They all went into helping the development process.

The beta trial of this app has now ended and we've moved to the next phase of app development. It is our intention to publish the source code of future apps as the binaries are released to the public.

Once again, thank you for being part of this.

Terence Eden Head of Open Technology - NHSX