search

ukhsa-collaboration / covid-19-app-android-ag-public

COVID19 Android app
Other
142 stars 31 forks source link

Don't show the no symptoms confirmation dialog if no symptoms are selected #14

Closed AWare closed 4 years ago

AWare commented 4 years ago

The dialog that states "Any selected symptoms will be unselected" is a little confusing when no symptoms are selected. This PR removes it when no symptoms are selected. The change is speculative as I haven't built the app, and also hasn't updated the relevant test which I believe will fail at https://github.com/nhsx/covid-19-app-android-ag-public/blob/01f790a0ebefe20ba6ff7925e56dfd88911741bf/app/src/androidTestScenarios/java/uk/nhs/nhsx/covid19/android/app/questionnaire/QuestionnaireScenarioTest.kt#L188 and https://github.com/nhsx/covid-19-app-android-ag-public/blob/01f790a0ebefe20ba6ff7925e56dfd88911741bf/app/src/androidTestScenarios/java/uk/nhs/nhsx/covid19/android/app/questionnaire/QuestionnaireScenarioTest.kt#L213

nhs-covid19 commented 4 years ago

Thank you for your contribution to the NHS Covid-19 application. As this is not the primary working copy of the source code, we cannot apply the patch to this repository, otherwise it will diverge from the upstream code. When we fix the issue upstream it will become available in this repository at the next software release.