search

ukhsa-collaboration / covid-19-app-android-ag-public

COVID19 Android app
Other
142 stars 31 forks source link

Some text strings missing in the app #33

Closed liskin closed 4 years ago

liskin commented 4 years ago

Describe the bug Symptoms checkboxes are empty in the app, and the local covid alert level screen also misses all text.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Select symptoms' or 'Local Covid Alert Level'

Expected behavior Some or all text is missing, as demonstrated by the attached screenshots:

Screenshots Screenshot_20201018-165049_NHS Covid-19 Screenshot_20201018-165056_NHS Covid-19

If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

clentfort commented 4 years ago

Same for German users

mikedlr commented 4 years ago

@clentfort - newspaper article on the subject - apparently this applies to at least French and Spanish as well.

29antonioac commented 4 years ago

I can confirm this happens in my Poco F2 Pro, Android 10, set in Spanish. The first version of the app worked perfectly but after the first update it doesn't show the strings.

liskin commented 4 years ago

This seems to have been fixed by the latest update.

It's quite disappointing though that this repo isn't updated with the code that was deployed to Google Play. Almost as if the authors of the NHS app didn't understand how open-source works. :-(

29antonioac commented 4 years ago

Yes, it's fixed for me now. Hope they update the repo soon.

El jue., 29 oct. 2020 13:34, Tomáš Janoušek notifications@github.com escribió:

This seems to have been fixed by the latest update.

It's quite disappointing though that this repo isn't updated with the code that was deployed to Google Play. Almost as if the authors of the NHS app didn't understand how open-source works. :-(

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nhsx/covid-19-app-android-ag-public/issues/33#issuecomment-718755639, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6B5FYVCKWYRUYP4P3R5J3SNFVNFANCNFSM4S2NFACA .

skenaja commented 4 years ago

Repo seems to have been updated. Looks like it was fixed in 36ba4bd with a fallback to en for untranslated strings.

Shame they're not doing nice commit messages in this repo in line with the GDS guidelines.

nhs-covid19 commented 4 years ago

Thanks for your interest in the NHS Covid-19 project, and for reporting this issue. This was the result of incorrect fallback behaviour for untranslated strings, as @skenaja points out, and has now been fixed. With regard to commit comments, as has been discussed already in some of the other public repos for this app, this isn't the primary repository, so individual commit messages are not available. With regard to timely updates of the open source version, @liskin , we do endeavour to update the open source repos with the correct code corresponding to a release very quickly after a new version of the app is released - usually within a few minutes. This time it did take a bit longer, as there were quite a few new repositories, including all the code for our risk scoring algorithms. e.g. https://github.com/nhsx/riskscore-kt-public (and the corresponding Swift repos for iOS)

liskin commented 4 years ago

this isn't the primary repository, so individual commit messages are not available

Can you point us to the primary repository then?