search

ukhsa-collaboration / covid19-app-system-public

COVID19 app backend
Other
202 stars 53 forks source link

elif unreachable #2

Closed ghost closed 4 years ago

ghost commented 4 years ago

The condition in this line will never be triggered since it is subsumed by the if; any number greater than 500 is already greater than 300. Perhaps replace the elif by an if.

nhs-covid19 commented 4 years ago

Thanks for your interest in the NHS Covid-19 project. Yes - it looks like the specific error message for a 5xx error won't be logged, although a generic error message will be. We'll figure out if the specific 5xx message adds any value, and fix it as required. Good Spot!