search

ukhsa-collaboration / covid19-app-system-public

COVID19 app backend
Other
202 stars 53 forks source link

Minor - Best practice improvement - Check: CKV_AWS_86: "Ensure Cloudfront distribution has Access Logging enabled" #25

Closed dewhurstwill closed 4 years ago

dewhurstwill commented 4 years ago

Check: CKV_AWS_86: "Ensure Cloudfront distribution has Access Logging enabled" FAILED for resource: aws_cloudfront_distribution.this File: /src/aws/libraries/cloudfront_download_facade/main.tf:10-89 Guide: https://docs.bridgecrew.io/docs/logging_20

Check: CKV_AWS_86: "Ensure Cloudfront distribution has Access Logging enabled" FAILED for resource: aws_cloudfront_distribution.this File: /src/aws/libraries/cloudfront_upload_facade/main.tf:11-197 Guide: https://docs.bridgecrew.io/docs/logging_20

Check: CKV_AWS_86: "Ensure Cloudfront distribution has Access Logging enabled" FAILED for resource: aws_cloudfront_distribution.this File: /src/aws/libraries/cloudfront_submission_facade/main.tf:11-273 Guide: https://docs.bridgecrew.io/docs/logging_20

Check: CKV_AWS_86: "Ensure Cloudfront distribution has Access Logging enabled" FAILED for resource: aws_cloudfront_distribution.this File: /src/aws/libraries/cloudfront_distribution_facade/main.tf:11-331 Guide: https://docs.bridgecrew.io/docs/logging_20

Check: CKV_AWS_86: "Ensure Cloudfront distribution has Access Logging enabled" FAILED for resource: aws_cloudfront_distribution.this File: /src/aws/libraries/cloudfront_conpan_facade/main.tf:20-99 Guide: https://docs.bridgecrew.io/docs/logging_20

To Reproduce Steps to reproduce the behavior:

  1. Install https://github.com/bridgecrewio/checkov (Checkov is a static code analysis tool for infrastructure-as-code.)

Expected behavior Previously failed steps pass

nhs-covid19 commented 4 years ago

Thanks for your interest in the NHS Covid-19 project. A wide variety of security and policy scanning tools are used on the source code and the runtime systems for the application, and the output from these systems is fed back into the development process. All signals will be evaluated, and scheduled for remediation according to priority. This is a specific example of a policy that needs to be applied selectively. Various design decisions are made across the application to improve user privacy and anonymity.