search

ukhsa-collaboration / covid19-app-system-public

COVID19 app backend
Other
202 stars 53 forks source link

Link to API contract in repo readme.md is 404 #3

Closed Relequestual closed 4 years ago

Relequestual commented 4 years ago

The API contracts for all exposed endpoints based on a small number of patterns.

The "API contracts" link results in a 404 page. Content missing.

bobwhitelock commented 4 years ago

Fixed in https://github.com/nhsx/covid19-app-system-public/pull/4 (at least based on the file movements and renames in https://github.com/nhsx/covid19-app-system-public/commit/a41ee3c966c4f59ff0b1e7c3ff8aeb70b1c2d312).

thefisk commented 4 years ago

You beat me to it, Bob :)

enly1 commented 4 years ago

Worth calling out that there are many other broken links in the readme documents - https://github.com/nhsx/covid19-app-system-public/tree/master/src/aws for example, /src/aws/accounts, src/aws links are all broken - maybe worth a quick scan across the rest.

Relequestual commented 4 years ago

I just wanted to see what was being used =] Avro is OK I guess. Wanted to see OpenAPI or JSON Schema!

Krusty93 commented 4 years ago

API Contracts and Pattern links are still broken

Relequestual commented 4 years ago

@Krusty93 the PR is not yet merged.

nhs-covid19 commented 4 years ago

Thanks for your interest in the NHS Covid-19 project. We'll be looking at the links in the documentation and try to make sure they are consistent. Thanks for pointing this out.