search

ukhsa-collaboration / fingertipscharts

11 stars 6 forks source link

Forthcoming release of ggplot2 and fingertipscharts (again, sorry!) #11

Closed paleolimbot closed 4 years ago

paleolimbot commented 5 years ago

Sorry to bug you again, we just wanted to let you know that the upcoming release of ggplot2 includes several improvements to plot rendering, including the ability to specify lineend and linejoin in geom_rect() and geom_tile(), and improved rendering of text. These improvements will result in subtle changes to your vdiffr dopplegangers when the new version is released.

Because vdiffr test cases do not run on CRAN by default, your CRAN checks will still pass. However, we suggest updating your visual test cases with the new version of ggplot2 as soon as possible to avoid confusion. You can install the development version of ggplot2 using remotes::install_github("tidyverse/ggplot2").

If you have any questions, let me know!

sebastian-fox commented 5 years ago

Thanks @paleolimbot - will update appropriately

sebastian-fox commented 5 years ago

Hi @paleolimbot - apologies for not being able to work this out myself. I've updated the visual tests and all the checks pass on my local machine. However, I don't know how to ensure my travis-ci uses the dev version of ggplot2.

I suppose I don't need to and I can just wait for ggplot2 to be updated on CRAN.

Do you have a recommendation for how to handle this? Do you know when it is planned to be submitted to CRAN?

paleolimbot commented 5 years ago

Thanks for pointing this out...I should have included a bit about Travis when I opened the issue. We haven't submitted the release to CRAN yet, you'll have to temporarily use Remotes: tidyverse/ggplot2 in your DESCRIPTION or revert your dopplegangers until the release is final. Given that we might get comments back from CRAN that requires changes on our part, it may take a few weeks.

(if you try it, let me know if the Remotes thing works since I have no good way to check this)

sebastian-fox commented 5 years ago

Thanks @paleolimbot - I added Remotes: tidyverse/ggplot2 though my build didn't pass - it looks like a timeout error. I don't think this is an issue though - I will wait until the release of ggplot2 on CRAN and then update the vdiffr test cases then. Thank you for your help in any case...