ukhsa-collaboration / pygom

ODE modelling in Python
GNU General Public License v2.0
27 stars 20 forks source link

Adding Github actions as CI to verify Windows and MacOS #42

Closed edwintye closed 4 years ago

edwintye commented 4 years ago

Description

Due to issues such as https://github.com/PublicHealthEngland/pygom/issues/33, it became increasingly obvious that the current build via travis is insufficient as a form of certification of the library. The reason is that a number of the users do not work in a Linux environment.

Testing

Tests are replicated from TravisCI -> Github actions with two additional OS type in the form of Mac and Windows: https://github.com/edwintye/pygom/blob/d469ee2713124b7a5e10fac3e79abc3518356eff/.github/workflows/python.yml#L19

The addition OS require slight changes to how the environment is setup; changes to the installation processes are transparent as they are managed in CI.

Observations

In the successful builds, it is obvious that the tests run significantly slow on Windows compared to the other two system. This is probably of concern and should be investigated.

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@18bdd6a). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #42   +/-   ##
=========================================
  Coverage          ?   56.94%           
=========================================
  Files             ?       48           
  Lines             ?     4773           
  Branches          ?      954           
=========================================
  Hits              ?     2718           
  Misses            ?     1810           
  Partials          ?      245           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18bdd6a...d469ee2. Read the comment docs.