ukhsa-collaboration / pygom

ODE modelling in Python
GNU General Public License v2.0
27 stars 20 forks source link

Include parameter class & improve plotting #45

Closed jontycarruthersphe closed 4 years ago

jontycarruthersphe commented 4 years ago

Parameter class

Improved plotting

twomagpi commented 4 years ago

Hi Jonty, Looks interesting. could you add some correctness-of-function tests to the PR so that we can automatically check that the class is behaving as expected?

many thanks

Tom

jontycarruthersphe commented 4 years ago

Hi Tom,

Just to check, does this need to resemble a short example, similar to the tests in pygom/tests?

Thanks, Jonty

From: Thomas Finnie notifications@github.com Sent: 20 May 2020 13:51 To: PublicHealthEngland/pygom pygom@noreply.github.com Cc: Jonathan Carruthers Jonathan.Carruthers@phe.gov.uk; Author author@noreply.github.com Subject: Re: [PublicHealthEngland/pygom] Include parameter class & improve plotting (#45)

Hi Jonty, Looks interesting. could you add some correctness-of-function tests to the PR so that we can automatically check that the class is behaving as expected?

many thanks

Tom

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/PublicHealthEngland/pygom/pull/45#issuecomment-631453142, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO5FFMWKIPUIZHPD3M7GJOTRSPGZRANCNFSM4MJVLK3Q.


The information contained in the EMail and any attachments is confidential and intended solely and for the attention and use of the named addressee(s). It may not be disclosed to any other person without the express authority of Public Health England, or the intended recipient, or both. If you are not the intended recipient, you must not disclose, copy, distribute or retain this message or any part of it. This footnote also confirms that this EMail has been swept for computer viruses by Symantec.Cloud, but please re-sweep any attachments before opening or saving. http://www.gov.uk/PHE


jontycarruthersphe commented 4 years ago

I've added some tests that are similar to those for the existing estimation methods. I have also updated the default covariance matrix for the perturbation kernel, it now uses an optimal local covariance matrix.

twomagpi commented 4 years ago

Now merged into 0.1.7