Open stefanleh opened 5 years ago
Is there an artifact on Maven Central which will show the error? Or are you seeing the issue with an artifact from an internal repo?
I think a flag to control the behaviour might be best. Eg
mavenDependencyExport {
filterResolvable = true
}
This would allow the build to fail for unresolvable depencies, I'm not sure if that's desirable behaviour (I need to understand what an unresolvable dependency is)
Also, have you seen this?
protected Collection<Configuration> prepareConfigurations() {
if (!configurations.empty) {
return configurations
}
Collection<Configuration> defaultConfigurations = new LinkedHashSet<>()
defaultConfigurations.addAll(project.buildscript.configurations.findAll { it.canBeResolved })
defaultConfigurations.addAll(project.configurations.findAll { it.canBeResolved })
return defaultConfigurations
}
Yes, the same check is done here too: https://github.com/uklance/gradle-dependency-export/blob/master/src/main/groovy/com/lazan/dependency/export/MavenDependencyExport.groovy#L54
But it doesnt matter if the configuration is resolvable when the artifacts in them might not be.
Please see the PR.
There is an access to the file property of an unresolvable artifact in MavenDependencyExport.groovy: https://github.com/uklance/gradle-dependency-export/blob/master/src/main/groovy/com/lazan/dependency/export/MavenDependencyExport.groovy#L154
I think the
component.getArtifacts(MavenPomArtifact).
should be extended by filtering of the artifacts so we only use resolvable ones. If i find some time i will look into that myself but currently im very busy.Best regards, Stefan