search

uklance / gradle-dependency-export

Export maven dependencies from a gradle project to the file system
28 stars 15 forks source link

Idea: proper logging #4

Closed stefanleh closed 5 years ago

stefanleh commented 5 years ago

Hi Lance,

id like to introduce proper logging to the plugin:

logger.info(), logger.lifecycle() ...

The logger is provided by gradle itself, so all whats needed to be added are one-liners. I suggest logging of:

What do you think about it?

stefanleh commented 5 years ago

Please see pull request #5 .

uklance commented 5 years ago

Please see this commit https://github.com/uklance/gradle-dependency-export/commit/036344f18a3dd2df5301cc7ffc79051a7f549caa

Where I

  1. Put back you canBeResolved = true logic
  2. Log the names of the configurations being exported
  3. Sort and log the filenames exported at the end of the task
  4. Make the configurations property public

If you are happy with these changes, I'll publish a new release

If you're happy with these changes

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Sun, 24 Feb 2019 at 21:19, Stefan notifications@github.com wrote:

Please see pull request #1 https://github.com/uklance/gradle-dependency-export/issues/1 .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/uklance/gradle-dependency-export/issues/4#issuecomment-466818174, or mute the thread https://github.com/notifications/unsubscribe-auth/ABW1JE8v0llTfMYefx8UEP5kcT8jaFQ9ks5vQwHvgaJpZM4bOt24 .

stefanleh commented 5 years ago

Hi Lance, thank you for you changes. I'll rebase my PR on those tomorrow,

uklance commented 5 years ago

I've just released version 0.4 to plugin portal as I'm not sure im going to get to this again for a while Please give it a whirl when you get a moment

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Sun, 24 Feb 2019 at 21:51, Stefan notifications@github.com wrote:

Hi Lance, thank you for you changes. I'll rebase my PR on those tomorrow,

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uklance/gradle-dependency-export/issues/4#issuecomment-466820898, or mute the thread https://github.com/notifications/unsubscribe-auth/ABW1JNoEJ0a55R8-yOAqlFe6vTCEKXHNks5vQwlqgaJpZM4bOt24 .

stefanleh commented 5 years ago

Thanks for merging.