Add proper logging - Githubissues

uklance / gradle-dependency-export

Export maven dependencies from a gradle project to the file system

27 stars 14 forks source link

Add proper logging #5

Closed stefanleh closed 5 years ago

stefanleh commented 5 years ago

considered configurations -> warn
currently processed configuration -> info
copied resources -> info
exceptions when resolving parent poms -> error

Only warn and error are always logged by default. Info loggings can be seen by using --info flag of gradle.

coveralls commented 5 years ago

Coverage increased (+1.2%) to 96.296% when pulling a7ab046a614075163ddaf76aada86516a4e0dbe2 on stefanleh:master into ed3986e8a027f6e5a980d5fd6a607150578e97f5 on uklance:master.

uklance commented 5 years ago

Please see https://github.com/uklance/gradle-dependency-export/commit/036344f18a3dd2df5301cc7ffc79051a7f549caa

stefanleh commented 5 years ago

I'll rebase on your changes tomorrow.

stefanleh commented 5 years ago

Hi Lance, i've used tabs instead of spaces now for formatting as i guess thats what you've used as well. Also i've added logging for the case people try to set non resolvable configurations via the configuration methods.

stefanleh commented 5 years ago

Just added a proper testcase for the filtering of custom set non resolvable configurations.

uklance commented 5 years ago

Note, I've made the configurations collection public now so the isResolvable check will need to move to the task action rather than the configuration(...) methods

On Mon, 25 Feb 2019, 9:51 am Stefan, notifications@github.com wrote:

Just added a proper testcase for the filtering of custom set non resolvable configurations.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uklance/gradle-dependency-export/pull/5#issuecomment-466946893, or mute the thread https://github.com/notifications/unsubscribe-auth/ABW1JKTcm3m8rUkIa54xXrvAecWbU2eoks5vQ7I5gaJpZM4bOvaf .

stefanleh commented 5 years ago

Note, I've made the configurations collection public now so the isResolvable check will need to move to the task action rather than the configuration(...) methods

I've solved that topic using a custom setter method for configurations that uses the configuration method. Please have a look.

stefanleh commented 5 years ago

Hi Lance, did you find the time to review the PR yet?

uklance commented 5 years ago

Hi, I'm coding all week at work so don't tend to do much on the side on weekdays. I'll try to have a look on the weekend

On Wed, 27 Feb 2019, 7:09 am Stefan, notifications@github.com wrote:

Hi Lance, did you find the time to review the PR yet?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uklance/gradle-dependency-export/pull/5#issuecomment-467749578, or mute the thread https://github.com/notifications/unsubscribe-auth/ABW1JOpDE9q56vrT2P6LI65vfQdtSnKzks5vRi8vgaJpZM4bOvaf .

stefanleh commented 5 years ago

Ok, no worries.

stefanleh commented 5 years ago

Just updated the PR to your latest changes.