uklans / cache-domains

Domain Names required for LAN Content Cache DNS spoofing
MIT License
566 stars 526 forks source link

Add new CDN for Steam Failback #215

Closed mintopia closed 1 year ago

mintopia commented 1 year ago

What CDN does this PR relate to

Steam

Does this require running via sniproxy

Yes

Capture method

N/A

Testing Scenario

None

Testing Configuration

N/A

Sniproxy output

N/A

mintopia commented 1 year ago

Creating a PR to kick off discussion around this topic. Re-adding the Steam domains as a separate CDN to allow people to still intercept them for when Steam stops using the trigger domain and falls back to using the content servers directly.

Points for discussion:

Overall it's something I think we should include, but we should not prevent this from continuing to investigate the slicing issues with Steam.

DuzAwe commented 1 year ago

I manually set these domains in Pi-Hole, which has resolved my issues. Why not just roll back the previous removal of the Steam domains instead of creating a failover? It would reduce points of failure.

mintopia commented 1 year ago

The failover isn't anything to do with us - it's how Steam works. By having it as a separate CDN in cache-domains, it allows those who don't want to intercept all Steam domains to easily disable them.

The actual behaviour of it within lancache itself doesn't matter - Steam is detected based on User Agent, not the cache domains CDN definitions.

DuzAwe commented 1 year ago

I see. Made an assumption and was wrong. I have run this locally without issue and integrated it with my Pi-Hole set-up no issues seen.

mintopia commented 1 year ago

Valve have fixed this issue in the latest Steam Client. It no-longer forgets the lancache. Closing as we don't need this anymore.