uklans / cache-domains

Domain Names required for LAN Content Cache DNS spoofing
MIT License
566 stars 525 forks source link

Riot Valorant doesn't get cached #230

Closed grabupdev closed 6 months ago

grabupdev commented 1 year ago

Describe the issue you are having

When downloading Valorant through Riot Games Launcher, it doesn't get cached. Steam Games, for example Rocket League are working.

Describe your setup?

DNS Server: pfSense Firewall with 1.1.1.1 as upstream DNS I am using lancache-dns with the pfSense Firewall DNS IP as Upstream DNS. The IP of the lancache-dns is set as primary DNS on the Windows 11 Client. No secondary DNS Server is set.

Are you running sniproxy

no

DNS Configuration

USE_GENERIC_CACHE=true
LANCACHE_IP=10.10.10.50
DNS_BIND_IP=10.10.10.41
UPSTREAM_DNS=10.10.10.1
CACHE_ROOT=/opt/dlcache
CACHE_DISK_SIZE=500g
CACHE_INDEX_SIZE=500m
CACHE_MAX_AGE=3650d
TZ=Europe/Berlin

Other stuff

When checking iftop on the NIC that is used for caching, i can see while downloading Valorant, that the Traffic is going through the cache. But it doesn't get cached.

I have seen that there already was an issue for this #164 but that didn't help.

ciarancrocker commented 1 year ago

Updating this to add that this is still an issue. We see Valorant patching exclusively over HTTPS at the following hostnames:

These hostnames are poisoned to point to our cache according to the following file: https://github.com/uklans/cache-domains/blob/31b2ba1e0a7c419327cb97f589b508d78b9aecbf/riot.txt#L5

Our cache is configured with IP addresses in the subnet 10.10.0.0/22.

Tawmu commented 1 year ago

Maybe @v3n can help?

VibroAxe commented 11 months ago

@v3n anything you can assist with?

v3n commented 10 months ago

Hey folks, I'm no longer at Riot, but have reached out to my old colleagues.

xelaadryth commented 9 months ago

Oops, sorry this slipped off our radar for so long, getting some folks to look at this in the next few weeks.

xelaadryth commented 8 months ago

So for some context, the fetching of the release manifest does require SSL for https://valorant.secure.dyn.riotcdn.net, and that's unavoidable. However, after that initial step, patching should fall back to http://valorant.dyn.riotcdn.net as long as that IP resolves to a non-public IP range such as your 10..

Reading through some of these readmes I see that https should go through without issue, lemme look into that non-public ip range detection...

Also, to clarify, this issue doesn't happen with League of Legends?

MathewBurnett commented 8 months ago

The cache domains entry for lancache dns has had *.dyn.riotcdn.net redirect in it since jul 31st 2019. During that time valorant hasn't been falling back, lol has been working. I haven't looked at it recently but this issue was raised again here in sep 23. I expect its still not working as intended.

xelaadryth commented 8 months ago

The fact that lol was still working actually helps a lot, and we may have found the issue. Testing out some fixes locally, will let ya folks know when we have the fix, or when the fix may hit live.

jblazquez commented 8 months ago

Hi everyone,

I'm on the Riot patcher team and worked on the initial HTTP fallback feature for LAN parties some 5 years ago.

Thank you for letting us know about this issue, and sorry for taking so long to address it. We have fixed the problem and you should see caching working again with the next version of Riot Client in early April.

If you encounter issues with caching again, please feel free to ping @xelaadryth or myself and we'll do our best to look into it.

MathewBurnett commented 8 months ago

Much appreciated. Its always well received when we are able to tell our LAN goers the developers of their favorite games are trying to help us out.

jblazquez commented 7 months ago

Hi all,

I just wanted to update this thread and let you know that Riot Client v83 is now live and contains the fix for this issue. You should be able to cache Valorant downloads now.

Please let us know if you are still encountering issues.

Thanks!