Closed derekchall closed 1 year ago
I see the problem with the wall update = well spotted.
however, I don't think I like the proposed solution. The cast from bool to t_wall_state assumes knowledge of the actual values used which is not safe. They may change arbitrarily.
I suggest this alternative:
maze.set_wall_state(location, NORTH, frontWall ? WALL : EXIT);
Which also compiles to less code - bonus!
The compiler here on nano33 and normal nano does not show a reduction in code space used, how did you work that out? it's tested and works ok, I don't like casting either it's just better than the other nonsense I came up with.
The AVR compiler just shows a saller image if I change one of the assignments. The compilers will all treat it differently. You pushed the new revision to your fork but not to the pull request.
And how exactly do you do that? (no command line nonsense). Everything I can see shows 3 commits on that pull request.
From: Peter Harrison @.> Sent: 06 March 2023 00:42 To: micromouseonline/mazerunner-core @.> Cc: MicroMouse @.>; Author @.> Subject: Re: [micromouseonline/mazerunner-core] Update maze wall data correctly (PR #3)
The AVR compiler just shows a saller image if I change one of the assignments. The compilers will all treat it differently. You pushed the new revision to your fork but not to the pull request. — Reply to this email directly, view it on GitHub https://github.com/micromouseonline/mazerunner-core/pull/3#issuecomment-1455270409 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6LWRPAEM74OBJS5RULN4DW2UXDZANCNFSM6AAAAAAVQJRSCY . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AB6LWROLYZPUNWPLSMYOEXLW2UXDZA5CNFSM6AAAAAAVQJRSC2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSWXWVAS.gif Message ID: @. @.> >
Well, that was a bit odd. I went ahead and merrged and the latest changes were put in even though I could not see them in the messages.
Not going to worryabout it now.
Known exits in cells were not updated on the map correctly.