ukmojb / CustomFishing

https://www.curseforge.com/minecraft/mc-mods/customfishing
MIT License
0 stars 0 forks source link

`inLiquidItemChancePoolDimBiome` not working - all fishing lead to default #8

Open Krutoy242 opened 1 week ago

Krutoy242 commented 1 week ago

There is my ZenScript code (some lines removed):

#modloaded customfishing

import crafttweaker.item.IItemStack;
import crafttweaker.liquid.ILiquidStack;
import mods.customfishing.FishingInCustomLiquid.inLiquidItemChancePoolDimBiome;

val fishing = {
  <fluid:pyrotheum>: {
    <mysticalagriculture:chunk:17>: 0.5,
    <ic2:dust:16>: 0.5,
    <mysticalagriculture:fire_essence>: 0.5,
    <thaumcraft:crystal_essence>.withTag({Aspects: [{amount: 1, key: "ignis"}]}): 0.5,
    <quark:soul_bead>: 0.5,
    <tconstruct:shard>.withTag({Material: "fierymetal"}): 0.2,
  },
} as float[IItemStack][ILiquidStack]$orderly;

for fluid, tuple in fishing {
  for item, chance in tuple {
    inLiquidItemChancePoolDimBiome(fluid, '', item, chance, '', null);
  }
}

Now when I fishing in Pyrotheum (from mod Thermal Expansion) I still get default fishes, same as if I would fish from Water (item instantly disappeared btw):

javaw_jyMuI3Hm5D (1)

Even default example, cited in mod description, not working. This is my code:

mods.customfishing.FishingInCustomLiquid.inLiquidItemChancePoolDimBiome(<liquid:lava>, "", <minecraft:apple>, 0.9F, "", null);

As the result, fishing is happens extremely slow (1 fish per 60 seconds, even with Lure III ench), and fished items is match default fishing list (no apples).

ukmojb commented 2 days ago

Try 0.1.0

Krutoy242 commented 22 hours ago

Issue is not fixed on v0.1.0.

javaw_TTD2WDErfe