search

uknownothingsnow / CircleProgress

CircleProgress, DonutProgress, ArcProgress
3.81k stars 921 forks source link

DonutProgress min_size constraining upper bound not lower bound #124

Closed jasco closed 5 years ago

jasco commented 5 years ago

It appears that the following use of min(...) should be max(...):

https://github.com/lzyzsd/CircleProgress/blob/dd4625136c368335a3e47ac61ba40bd3cdb2c0a1/library/src/main/java/com/github/lzyzsd/circleprogress/DonutProgress.java#L366-L369

I also note that min_size doesn't appear to be used in any of the other shapes.

jasco commented 5 years ago

I guess the intent was to avoid overriding the user supplied maximum when the value was less than the supplied min_size. I'd prefer smarter auto sizing, but perhaps this is working as intended. Apparently it is expected that the widget size is specified using an exact size. The variable min_size might in this case better be called default_size. Closing for now.