search

ukoethe / vigra

a generic C++ library for image analysis
http://ukoethe.github.io/vigra/
Other
407 stars 191 forks source link

Replace bind1st and bind2nd by bind #500

Closed constantinpape closed 2 years ago

constantinpape commented 2 years ago

Closes #481

constantinpape commented 2 years ago

Note that this change is now included in the conda-forge pacakge, see https://github.com/conda-forge/vigra-feedstock/pull/78. I have also verified that vigra and downstream pacakges can be build with c++17 with this patch.

It would still be very good to merge this here (and then get rid of the patch in conda-forge once there is a new release).

hmeine commented 2 years ago

Great; I have not been monitoring my GitHub notifications, so I missed this, but I am glad you took this on!

constantinpape commented 2 years ago

Thanks for merging this @hmeine! Do you think there is any chance to get a new vigra release at some point? The conda-forge recipe for vigra is full of patches for the changes in this PR and others that are merged long ago and it would be great to clean this up at some point. See https://github.com/conda-forge/vigra-feedstock/blob/master/recipe/meta.yaml.

hmeine commented 2 years ago

Good question. I would not want to do that without talking to @ukoethe. But I think we should find a way to define a streamlined release process and get a new official version out with all the fixes since the latest release – would be a big pity if we couldn't achieve that!

constantinpape commented 2 years ago

Thanks @hmeine! Do you want to contact @ukoethe about this? (I think he also doesn't check github notifications regularly right now). Or I could also write him a mail about this.

hmeine commented 2 years ago

Good idea, then maybe you write an email to him with me in CC (MEVIS, GMX or Uni Bremen addresses would all work).