search

ukoethe / vigra

a generic C++ library for image analysis
http://ukoethe.github.io/vigra/
Other
407 stars 191 forks source link

cpp11 #507

Closed lnw closed 11 months ago

lnw commented 2 years ago

Closes #544

Silence Wdeprecated-copy warnings by g++-11/linux. Breaks any pre-11 c++ versions!

The choice of defaulting/deleting member function simply replicates the previous implicit choices. The two lines in multi_array.hxx and numpy_array_taggedshape.hxx may warrant some looking at (although also here, I'm just replicating the previous implicit behaviour)

lnw commented 2 years ago

I see that most of the checks have failed. Looking at the errors, it looks to me like that's a problem of the setup and has nothing to do with the patch.

hmaarrfk commented 11 months ago

We have started to "revive" the project now that we got some CIs working again. If you wanted to rebase onto master, that would be great and we can test again.

hmaarrfk commented 11 months ago

Rebased and testing in https://github.com/ukoethe/vigra/pull/544

hmaarrfk commented 11 months ago

thank you!

lnw commented 11 months ago

I see you were faster than me, thanks!

We have started to "revive" the project now that we got some CIs working again. If you wanted to rebase onto master, that would be great and we can test again.