search

ukoethe / vigra

a generic C++ library for image analysis
http://ukoethe.github.io/vigra/
Other
410 stars 191 forks source link

Fix CIs #514

Closed hmaarrfk closed 1 year ago

hmaarrfk commented 1 year ago

I spoke with ukoethe by email and he agreed that dropping python 2.7 would be ok.

Closes: https://github.com/ukoethe/vigra/issues/502

hmaarrfk commented 1 year ago

100% tests passed, 0 tests failed out of 55

hmaarrfk commented 1 year ago

@k-dominik I am trying to keep this to a "CI only change" and I think I'm close.

I'm struggling with windows. If you have a machine handy and want to debug that would be greatly appreciated.

OSX is close, but for some reason i'm getting a segfault. fun!

k-dominik commented 1 year ago

Hi @hmaarrfk,

awesome effort! I'll look into the windows build tomorrow :)

k-dominik commented 1 year ago

Hi @hmaarrfk,

is there a reason for the testing strategy with OSX-> py37, linux-> py38, py39, and windows-> py310?

hmaarrfk commented 1 year ago

is there a reason for the testing strategy with OSX-> py37, linux-> py38, py39, and windows-> py310?

Just trying to get a "spread" of python versions without building the full matrix. 3 x 4 -> 12 builds is a little "too much".

hmaarrfk commented 1 year ago

@k-dominik i'm somewhat tempted to skip OSX and merge this as is. what do you think? There seems to be a few more PRs to modernize the code base that would go through more easily once we have linux + windows CIs in place.

k-dominik commented 1 year ago

Hello @hmaarrfk,

yes, let's go ahead and merge this. I am always thinking of getting back to vigra and I promise I will ;). Thank you for persisting here!

Cheers Dominik