Closed k-dominik closed 1 year ago
update:
When I left this, I saw some problems with openexr
and vigra picking up different versions of imath
, with the suspicion that openexr
doesn't correctly specify the version of imath
. Then I got sick. In the meantime I saw some activity... and with the latest openexr
we are down to 4 test failures... Investigating...
update: funny enough the only overlap with test failures on my silicon mac is vigranumpy....
k, the osx tests run through now on my intel macbook air.
Hm.. okay that's strange. Locally the tests pass, but in CI, there seems to be an error related to libpng
.
The failing tests issue
Application built with libpng-1.4.12 but running with 1.6.39
e.g. here
I tried finding how in the world it picks it up...
My local env is exactly the same, it also picks up the same lib, but on ci it claims version 1.4.12
The OSX Stuff seems pretty Conda-forge specific. Maybe we should report to boost at conda-forge? or ask them for advice.
how about pinging @jakirkham first - in the end that's the originator of the change.
For reference, we're discussing the following code snippet:
IF(APPLE)
SET(VIGRANUMPY_LIBRARIES ${Boost_PYTHON_LIBRARY})
ELSE()
SET(VIGRANUMPY_LIBRARIES ${Python_LIBRARIES} ${Boost_PYTHON_LIBRARY})
ENDIF()
linking agains both Python_LIBRARIES
and Boost_PYTHON_LIBRARY
results in a segfault. Is this a boost.Python
bug, or something inherent to using conda to build?
if I have some time I'll try to construct a "clean" example, not using conda and see if that issue persists (before that it would be hard to open an issue with boost/conda-forge/cmake).
I think this is due to some static linking in Python at conda-forge. I remember having run into this somewhere else.
I'm sorry I "moved" that patch. it makes finding the original author hard. I think it was jakirkham.
k - looks good. Tests still pass :)
okay - finally it seems to work. I'll summarize the changes here:
libpng
(despite stating otherwise, this seems to be a cmake bug) - resolved by changing the order of package discovery viaCMAKE_FIND_FRAMEWORK
(andCMAKE_FIND_APPBUNDLE
).fixes #535, closes #523, closes #490
I would also suggest to close #469 - don't think nightly builds are needed now that vigra gets some love.
My comments further down were mostly recording thoughts during debugging, and don't need to be read now anymore :)