search

ukoethe / vigra

a generic C++ library for image analysis
http://ukoethe.github.io/vigra/
Other
409 stars 191 forks source link

Modernize codebase for python 3+ (more) #570

Closed a-detiste closed 1 month ago

a-detiste commented 1 month ago

I'll check your issues. Per habit I allways start with a bit of cleansing with pyflakes & mypy.

hmaarrfk commented 1 month ago

these look great thanks!

hmaarrfk commented 1 month ago

I merged without waiting for windows since the changes seemed sane. Its nice to have these cleanups in the master branch when starting with the more challenges fixes.

a-detiste commented 1 month ago

vigranumpy/lib/__init__.py:443:13: undefined name 'vigra'

hmaarrfk commented 1 month ago

is that a linter warning? how do yo uhit the code.... all the tests passed on linux....

a-detiste commented 1 month ago

numpy ended up loaded there anyway from one of the * import... but that's stretching luck

hmaarrfk commented 1 month ago

sorry i don't follow. if you make a PR i will review.