search

ukrbublik / react-awesome-query-builder

User-friendly query builder for React
https://ukrbublik.github.io/react-awesome-query-builder
MIT License
1.91k stars 490 forks source link

Show imported value initially in MUI autocomplete inputs #1065

Closed dalen closed 2 weeks ago

dalen commented 2 weeks ago

When importing a query from for example json logic, show the imported value initially in autocomplete inputs that use an asyncFetch. Before this they would show no value at all until you clicked on them and they loaded all the options.

codesandbox[bot] commented 2 weeks ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 4:56pm
react-awesome-query-builder-sandbox 🛑 Canceled (Inspect) Jun 19, 2024 4:56pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview Jun 19, 2024 4:56pm
codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34557bd59181513212c14ebbcc4f425c86144f12:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.04%. Comparing base (d4690b1) to head (34557bd).

Files Patch % Lines
...ages/mui/modules/widgets/value/MuiAutocomplete.jsx 0.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1065 +/- ## ========================================== - Coverage 82.05% 82.04% -0.01% ========================================== Files 211 211 Lines 10969 10969 Branches 1328 1328 ========================================== - Hits 9001 9000 -1 Misses 1355 1355 - Partials 613 614 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ukrbublik commented 2 weeks ago

Thanks for the PR! I had to add a fix for a case when autocomplete value is empty, like when you add new rule with autocomplete field