ukrbublik / react-awesome-query-builder

User-friendly query builder for React
https://ukrbublik.github.io/react-awesome-query-builder
MIT License
2.02k stars 504 forks source link

add `okType` to ConfirmModalProps #1129

Closed schiller-manuel closed 3 weeks ago

schiller-manuel commented 4 weeks ago

should this be a string instead of "danger"?

codesandbox[bot] commented 4 weeks ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 8:54pm
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 8:54pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview Nov 4, 2024 8:54pm
codesandbox-ci[bot] commented 4 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 633e2e029849a7de16c767689ea6abe753becfa4:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration
codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.08%. Comparing base (f555509) to head (633e2e0). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1129 +/- ## ======================================= Coverage 82.08% 82.08% ======================================= Files 212 212 Lines 11184 11184 Branches 1343 1343 ======================================= Hits 9180 9180 Misses 1378 1378 Partials 626 626 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ukrbublik commented 4 weeks ago

I think okType is not used

schiller-manuel commented 4 weeks ago

well it occurs in the documentation and examples and could potentially be used by a UI library.

ukrbublik commented 4 weeks ago

Ok, please use string instead of "danger"