Closed giordano closed 8 months ago
Probably this isn't the most efficient algorithm out there, but this takes a bunch of microseconds on my laptop, so hopefully it won't be a major performance bottleneck.
I agree that this is extremely unlikely to be a problem so I have no issues with it.
LGTM (but I can't approve it until you re-request a review).
I have tested this works on the CSD3 Icelakes as expected (by passing -S num_nodes=48
for the ITT-64n
test).
Thanks!
Should fix https://github.com/ukri-excalibur/excalibur-tests/issues/237#issuecomment-1827595717. I followed the suggestion in https://github.com/ukri-excalibur/excalibur-tests/issues/237#issuecomment-1828323882. Probably this isn't the most efficient algorithm out there, but this takes a bunch of microseconds on my laptop, so hopefully it won't be a major performance bottleneck:
CC: @mirenradia.