search

ukri-excalibur / excalibur-tests

Performance benchmarks and regression tests for the ExCALIBUR project
https://ukri-excalibur.github.io/excalibur-tests/
Apache License 2.0
19 stars 16 forks source link

Require numpy 1 due to incompatibility with Streamlit #335

Closed tkoskela closed 3 months ago

tkoskela commented 3 months ago

Update bokeh version to work with latest numpy

Closes #334

tkoskela commented 3 months ago

I actually meant to use >= not ==, let me fix

tkoskela commented 3 months ago

Ah, there was a reason for that specific version. This could be a problem

StreamlitAPIException: Streamlit only supports Bokeh version 2.4.3, but you have version 3.5.0 installed. Please run pip install --force-reinstall --no-deps bokeh==2.4.3 to install the correct version.
tkoskela commented 3 months ago

It's failing on

    assert all(c in EXPECTED_FIELDS for c in df.columns.tolist())

On a quick look through the perflog the fields look ok. Maybe something has changed in the spac spec dict?

pineapple-cat commented 3 months ago

If it helps, I think the change causing this may have taken place 28 - 29 May. Using the line plot PR as reference again, all tests were passing on the 28th, but when I pushed some inconsequential changes on the 29th this specific test started failing.

tkoskela commented 3 months ago

The field version has changed to reframe version (I assume in a new version of ReFrame). I'm running 4.6.2. I updated it in the test and now it passes. I noticed we don't have whitespace in other field names. Is that going to cause any issues @pineapple-cat?

Edit: I should probably update the required version of ReFrame with this.

pineapple-cat commented 3 months ago

Of course, I forgot about ReFrame field name updates; thank you for finding the issue.

tkoskela commented 3 months ago

This change seems to have happened in ReFrame 4.6.1. Are we happy to update the requirement to that?

giordano commented 3 months ago

I think so. Better to be explicit about the actually supported versions.