ukris / typhoonae

Automatically exported from code.google.com/p/typhoonae
0 stars 0 forks source link

read_crontab requires for crontab entries to have a comment #96

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Hi there,

Just stumbled across this: when launching an app with --crontab, the function 
read_crontab() in apptool.py is executed which splits up the crontab lines 
based on a regular expression defined in CRONTAB_ROW.

The issue with the regular expression is that is expects every entry in the 
crontab to end with a "#something" comment at the end. If it doesn't, the last 
group doesn't match and returns a "None", which in return raises a NoneType 
error in "tmp.write('\n'.join([' '.join(r) for r in tab])+'\n')" line of 
write_crontab() function in the same file. (since one of the r's in tab is not 
a string, but None).

Should be an easy enough fix I guess to set the last group in the regular 
expression to optional.

Let me know if you need any more details.

Cheers

Original issue reported on code.google.com by mbachw...@gmail.com on 3 Jul 2012 at 10:48