search

uktrade / enquiry-mgmt-tool

Enquiry management tool supporting the Ready to Trade campaign
https://uktrade.github.io/enquiry-mgmt-tool/
MIT License
1 stars 2 forks source link

The tag displaying countries are displaying country codes #62

Open rahulbist opened 4 years ago

rahulbist commented 4 years ago

The tag displaying countries within the Enquiry Management Tool should display country names and not the country code.

Additionally, it seems currently, we are outputting the country name for some and the country code for others:

image

saruniitr commented 4 years ago

This is mainly because of mismatch in reference data. The great website uses abbreviate country names for the choices but in our app we use full name. When new enquiries are fetched from AS and parsed to create new instances currently we are not doing the mapping resulting in this bug. Plan is to use the same reference data in our app also but directory-constants was not supporting Django 3 or higher which is required for us. A PR has been submitted and it is merged so we can take up that task and fix this issue. https://github.com/uktrade/directory-constants/pull/133

rahulbist commented 4 years ago

To complete this issue and resolve the bug, the outstanding task is to map the country codes obtained from great.gov.uk (https://www.registers.service.gov.uk/registers/country) and map these country codes to the country codes within the Enquiry Management Tool repo.

When the mapping is achieved, this will then eradicate the Enquiry Management Tool displaying country codes instead of the full country name