search

uktrade / fargatespawner

Spawns JupyterHub single user servers in Docker containers running in AWS Fargate
MIT License
47 stars 21 forks source link

Documentation issue #5

Closed JasonIamAUnixAdmin closed 5 years ago

JasonIamAUnixAdmin commented 5 years ago

I am working on getting this setup for our current notebook setup. In the readme to use rolls for ECS auth this is what is written from jupters3 import FargateSpawnerECSRoleAuthentication

Should that be from fargatespawner import FargateSpawnerECSRoleAuthentication

I can do a PR if so. Thanks

michalc commented 5 years ago

Hi @JasonIamAUnixAdmin

Thanks for the report, and apologies for the delay in getting back to you. Yes, you're right in the that README is wrong here. A PR fixing this would be very much appreciated.

Thanks,

Michal

michalc commented 5 years ago

Fixed by https://github.com/uktrade/fargatespawner/pull/6