search

ukwa / ukwa-pywb

GNU General Public License v3.0
11 stars 3 forks source link

Build instructions need updating as it may fail using setup.py #107

Open ldbiz opened 12 months ago

ldbiz commented 12 months ago

Invoking setup.py directly is deprecated see also this pywb issue

Documentation should be updated to reflect as there may be build issues otherwise.

eg. https://github.com/ukwa/ukwa-pywb/blob/master/README.md?plain=1#L44

should be ok with "pip install ." as a replacement.

Setup.py itself is still used by the commands replacing the direct invocation.

anjackson commented 12 months ago

I noticed the same on the parent project: https://github.com/search?q=repo%3Awebrecorder%2Fpywb+%22setup.py+install%22+language%3AreStructuredText&type=code

Perhaps a good idea to make PRs to update both?

ldbiz commented 9 months ago

I've spent some time looking into this to see what is involved in also changing the existing setup.py invocations as well as the docs, as that would in theory fix the related install issues.

There are however a number of custom commands in both repos setups - they should still run ok (eg. here) if the scope is limited to bare install replacement (changing "python setup.py install" to "pip install .") but even with that the testing might be significant and its not clear it is a priority at the moment, so I will stick to the original scope here and just amend documentation.