search

ukwa / ukwa-pywb

GNU General Public License v3.0
11 stars 3 forks source link

Redirect into reading room viewers not working #82

Closed anjackson closed 2 years ago

anjackson commented 2 years ago

Trying to get https://www.webarchive.org.uk/wayback/archive/20080215111724/http://www.abi.org.uk/

Page shows links to Reading Room access. e.g. https://bl.ldls.org.uk/welcome.html?20501101120000/http://www.abi.org.uk/

That uses a 2050 timestamp to force the most recent version, but it seems this does not work. The item does not come up, but this works:

https://bl.ldls.org.uk/welcome.html?20080215111724/http://www.abi.org.uk/

And even this works!

https://bl.ldls.org.uk/welcome.html?10501101120000/http://www.abi.org.uk/

(redirecting to the earliest instance.)

So update this to use the supplied timestamp, and failing that, a very early timestamp, like 1990 or something.

anjackson commented 2 years ago

Thought it might be a 2038 thing, but while 2021 works, but 2022 does not. Very odd. Best plan for now is to aim for 19900101120000.

Note that actual real entries like 20220405104602/https://www.bl.uk/ also don't work! So PyWB will have to force the 1990 date if the date is > 20210630000000 (note that 20211230000000 didn't work).

anjackson commented 2 years ago

Okay, rolling 2.6.4.2 with this patch included.

anjackson commented 2 years ago

Works great on DEV. Needs rolling out on Monday.