ukwa / ukwa-pywb

GNU General Public License v3.0
11 stars 3 forks source link

WIP Custom Viewers Initial Setup #85

Closed ikreymer closed 1 year ago

ikreymer commented 2 years ago

This setup adds a PDF and EPUB viewers, and a couple of test cases, under the reading-room collection. The system uses the existing content-type filtering, and also adds extension filtering for epubs, as they often do not have a custom mime type.

The sample data includes the following URLs:

This also uses a new branch of pywb that adds an ir_ modifier, that supports unrewritten content but with Location headers still being rewritten to simplify loading unrewritten content.

To Do

ikreymer commented 2 years ago

Currently, this PR modifies the existing reading-room collection, but can make a copy of that if the config is needed for something else.

anjackson commented 2 years ago

No, it's fine to use the reading-room collection - this is what it's for.

Aside: Did you ever look at integrating Ruffle for Flash playback? I seem to remember you did, but can't find a reference... Ah, is it the JS implementation!? ... Ah, yes it is --- I've vaguely struck by the similarity of what we're doing with some of the aims of the Universal Viewer project, and whether long term we should look at a more generic JavaScript-based playback system supporting a growing range of formats through some modular means...

anjackson commented 2 years ago

Some issues I'm having, in https://github.com/ukwa/ukwa-pywb/issues/92

anjackson commented 1 year ago

Note that I've merged these changes into #101 as I want to do one big round of testing. Will leave this PR open for now.

anjackson commented 1 year ago

I've changed my mind. We need to proceed with this separate from the 2.7 Vue timeline changes. So I've brought @tw4l latest updates into this PR and will merge it and mint a 2.6.9-LDA-1 version. This will probably involve back-porting some changes from the 2.7.x branch.

anjackson commented 1 year ago

This has been updated to include more recent changes, and backporting updates to the terms pages.

anjackson commented 1 year ago

There a still a few translation gaps, but hanging on to this PR for so long is causing problems, so I'm merging