search

ukwa / ukwa-services

Deployment configuration for all UKWA services stacks.
Apache License 2.0
4 stars 5 forks source link

Deduplicate tests? #66

Closed ldbiz closed 2 years ago

ldbiz commented 2 years ago

The repeated tests in browse.robot might lend themselves to being simplified/deduplicated using a custom keyword.

anjackson commented 2 years ago

Yes, that sounds like a good idea, although I can't quite tell whether this would make it harder to understand?

One simplification would be to only do a single check after log out:

https://github.com/ukwa/ukwa-services/blob/947cf79bf0f19cd81dd1987104fa76e6713ed74d/ingest/ingest_tests/tests/browse.robot#L58-L60

Looking at it now, going back to them all yet again seems like overkill.

anjackson commented 2 years ago

I simplified the tests as per my comment above: https://github.com/ukwa/docker-robot-framework/commit/1664969f964241a4e5c2a9b367c5279bdb6e9eae

I'm happy with that for now, but it's up to you if you want to deduplicate further @ldbiz