ukwa / ukwa-services

Deployment configuration for all UKWA services stacks.
Apache License 2.0
5 stars 5 forks source link

Excellent changes specific to beta and prod deployment #7

Closed GilHoggarth closed 4 years ago

GilHoggarth commented 4 years ago

Includes use of w3act image envar. Secrets and envars use different files. 2020...sh Postgres database changes example pulls in both secrets and envars files.

You'll be very happy with these changes...

anjackson commented 4 years ago

There's quite a lot of unused env-var in there, which you could drop. Otherwise looks fine.

e.g.

export W3ACT_PORT=9000
export W3ACT_JMX_PORT=1899
export POSTGRES_PORT=5432
export WAYBACK_PORT=9080
export API_PORT=8000
GilHoggarth commented 4 years ago

I think the POSTGRES_PORT is used in the docker-compose.yml. Otherwise I consider it the developer's responsibility to include or drop the envars they need ;)

anjackson commented 4 years ago

hah fair enough.