ukwa / w3act

w3act is an annotation and curation tool for building web archive collections
Apache License 2.0
19 stars 6 forks source link

Possibility that Targets are added as Watched Targets by mistake #621

Closed crarugal closed 1 year ago

crarugal commented 5 years ago

There are Expert and Archivist users who have permission to use DDHAPT and it seems that this additonal permission changes the UI slightly. The outcome may be leading users to accidently make a Target a Watched Target. This can occur if a DDHAPT user is logging in and the homepage is the Watched Target page.

Currently, a user without DDHAPT access can click on the W3ACT logo and will be taken to this screen:

https://www.webarchive.org.uk/act

Screenshot 2019-06-27 11 36 40

However, a user with DDHAPT permissions will click on the same W3ACT logo and be redirected to this screen: https://www.webarchive.org.uk/act is redirected to https://www.webarchive.org.uk/act/overview/watchedtargets

Screenshot 2019-06-27 11 40 14

This could be an issue whereby a DDHAPT users may be searching for a target but accidentally makes it a Watched Target by unintentionally entering a URL in the Watched Target page:

image

Perhaps the redirect for DDHAPT users should be removed and remain https://www.webarchive.org.uk/act. Or the Watched Target page is redesigned to look significantly different to https://www.webarchive.org.uk/act/targets/lookup

nicolabingham commented 5 years ago

Thanks @crarugal. It sounds like making the redirect for DDHAPT users to https://www.webarchive.org.uk/act would be easier, rather than redesigning the WT page.

anjackson commented 5 years ago

I think this isn't an issue, because I think it's just a shortcut to the usual lookup page, and doesn't hard-code in any additional logic to do with document harvesting. However, it's best if @min2ha check this is the case. Maybe there's some weird JavaScript/cookie stuff going on?

min2ha commented 5 years ago

I've tested already and couldn't find any malfunction related to (de)selection of watched targets. No idea how unauthorised watched targets could be added. Maybe it is some side effect of previous ACT migration?

Clarification on roles

ADD TARGET Any role starting from 'user' (aka 4) and higher priority can add new target Targets > Look up a URL or Document Harvesting New Target which will be forwarded to the same Targets > Look up a URL

WATCH TARGET In order to watch target, it needs to be create at first, so if unique URL was entered at New Target or Targets > Look up a URL input field, it will be redirected to Targets > Target (edit form) Any role starting from 'expert user' (aka 3) and higher priority can (de)select to watch the target if it has ownership of it Any role starting from 'archivist' (aka 2) can (de)select to watch any existing target

Role 'user' (aka 4) cannot (de)select to watch the target even if it has ownership of it

BTW update on users with DDHAPT is needed.

min2ha commented 5 years ago

Thanks to @nicolabingham, got new ideas about how unauthorised watched targets could appear in ACT.

AFAIK all users with DDHAPT are authorised to add Targets to Watch.

But some problems related to data or permission sync still exist.

image

Actually extra things should be done:

HelenaByrne commented 5 years ago

A screen shot of my ACT homepage image

HelenaByrne commented 5 years ago

The screen shot and links are targets that are marked as Watched Targets but I didn't activate them to be watched.

The individual target links:

https://www.webarchive.org.uk/act/targets/91018

https://www.webarchive.org.uk/act/targets/57526

https://www.webarchive.org.uk/act/targets/47987

https://www.webarchive.org.uk/act/targets/37989

crarugal commented 2 years ago

I'm still seeing targets added to my watch list, additions that I've not made. Something that's been ongoing since the ticket was raised - although I don't believe they are being added by mistake through an accidental user workflow. image

crarugal commented 2 years ago

It looks like "The Skeptic" was recently added as Watched: I just noticed that a new target had been added to my watched list: image

I don't usually access ACT through the homepage, so it could have been Watched for some time. It looks like the record was also recently updated: https://www.webarchive.org.uk/act/targets/166891 image image

Looking at recent ACT activity(10-10-2022 13:42)

These are the most recent users (login time should be +1 hour to match current BST): image

These are the targets that were created at around the same time "The Skeptic" target was updated (looking at targets around 13:42) image

These are the targets that were updated on the 10/10/22: image

Leontien and Alice aren't able to Watch targets, but looking at the times, it's possible another ACT user updated "The Skeptic" to Watched. I will follow up with an email to recent logged-in users and see if they updated "The Skeptic"

crarugal commented 2 years ago

It seems that a curator edited "The Skeptic" to remove a URL(https://www.skeptic.org.uk/category/alternative-medicine/) from that target and make it a target on its own (https://www.webarchive.org.uk/act/targets/168708/) - unclear if this could cause it. Still investigating

crarugal commented 1 year ago

This may need further investigation, but, for now, the solution is to redirect all users (even with DDHAPT logins) to the same page. This may help because DDHAPT users when logged in, will see a list of all of their watched targets and what looks like a search bar; the search bar may have been accidentally used for search for a target, which is not the intended use: image

To get around this, all users will now see the /act/about page

Current homepage after login (as DDHAPT user): image

Fix: image