Send button on Crawl Permission view does not send email

emacglone commented 2 years ago

A permissions email sent last week to an internal email at NLS as a test, has not arrived to the inbox or junk mail folder.

anjackson commented 2 years ago

Hm, just tried sending a permissions email to my own non-BL email address and it worked okay. Can you tell me the internal email address (via BL email if you prefer) and I'll see if I can reproduce the problem.

emacglone commented 2 years ago

Hi Andy,

Thanks for looking at this!

The email is: @.**@.>

Eilidh

Eilidh MacGlone Web Archivist | Collections Management

National Library of Scotland 92 Cowgate, Edinburgh EH1 1JN Tel: +44 0131 623 3934 Email: @.**@.> Website: www.nls.ukhttp://www.nls.uk/ @.*** Facebook: /NationalLibraryofScotland

From: Andy Jackson @.> Sent: 18 May 2022 14:44 To: ukwa/w3act @.> Cc: MacGlone, Eilidh @.>; Author @.> Subject: Re: [ukwa/w3act] Test permission email is not arriving (Issue #674)

External Email: This email originated from outside of the National Library of Scotland. Do not click links or open attachments unless you have verified the sender and know the content is safe.

Hm, just tried sending a permissions email to my own non-BL email address and it worked okay. Can you tell me the internal email address (via BL email if you prefer) and I'll see if I can reproduce the problem.

— Reply to this email directly, view it on GitHubhttps://github.com/ukwa/w3act/issues/674#issuecomment-1130036540, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADHNQMHHYJ4I7MKXSARF2X3VKTX2HANCNFSM5WBPWH4Q. You are receiving this because you authored the thread.Message ID: @.***>

National Library of Scotland, Scottish Charity, No: SCO11086

Our reading rooms, exhibitions, caf� and shop are open. Visit our website to join the Library or pre-order material.

This communication is intended for the addressee(s) only. If you are not the addressee please inform the sender and delete the email from your system. The statements and opinions expressed in this message are those of the author and do not necessarily reflect those of National Library of Scotland. This message is subject to the Freedom of Information (Scotland) Act 2002 and data protection legislation. Personal data sent to the Library by email will be processed in accordance with the Library�s privacy information available at www.nls.uk/privacy. No liability is accepted for any harm that may be caused to your systems or data by this message. If this communication relates to a request for information from the Library under the Freedom of Information (Scotland) Act 2002 (FOISA) and you are dissatisfied with our response, you may ask the Library to conduct a review of our decision(s) regarding the supply of information. To begin a review please contact us in writing or other recorded form and describe the original request, explain your dissatisfaction, and provide an address for correspondence. You have 40 working days from receipt of our response to your request to submit a request for review. We will respond within 20 working days of receipt of your request. If you are still dissatisfied after a review you may ask the Scottish Information Commissioner to intervene. You may launch an appeal with the Commissioner online at: www.itspublicknowledge.info/Appeal. For more information about FOISA please visit: www.itspublicknowledge.info.

Before you print please think about the ENVIRONMENT

crarugal commented 2 years ago

I tested out a permission request with this target, a target created by a test NLS ACT user: https://www.webarchive.org.uk/act/targets/160705

I used these settings:

I released the licence and it was sent out: https://www.webarchive.org.uk/act/crawlpermissions/51700

Eilidh, are the licence that NLS send out, set up in a similar way? https://www.webarchive.org.uk/act/crawlpermissions/51700

anjackson commented 2 years ago

Sorry @emacglone can you send me that email address some other way, e.g. direct email to my BL account? I think GitHub ate it.

crarugal commented 2 years ago

I think this could be down to the release process.

When I release the licences, I press send in the queued view: https://www.webarchive.org.uk/act/crawlpermissions/list?s=updatedAt&organisation=1

Once sent, the 27 queued licences should be sent out, and their status is automatically changed to pending.

Sending an NLS licence in the queued status does work:

However, if you go into a queued licence, and manually change a licence from queued to pending, then the system doesn't email out the licence to the recipient:

So if I go to this test target, with a pending licence: https://www.webarchive.org.uk/act/crawlpermissions/51714 and then press send, nothing will happen as the system thinks this licence has already been sent, and is awaiting for it to be granted of rejected by the recipient

Pressing send on a pending licence does take you back to the crawl permissions landing page, but the licence will not be emailed out.

emacglone commented 2 years ago

I have tried with oldhttps://www.webarchive.org.uk/act/crawlpermissions/47948 and newhttps://www.webarchive.org.uk/act/crawlpermissions/51715 test targets and it doesn’t seem to work, they just stay “QUEUED”:

https://www.webarchive.org.uk/act/crawlpermissions/list?s=updatedAt&organisation=3

Eilidh

Eilidh MacGlone Web Archivist | Collections Management

National Library of Scotland 92 Cowgate, Edinburgh EH1 1JN Tel: +44 0131 623 3934 Email: @.**@.> Website: www.nls.ukhttp://www.nls.uk/ @.*** Facebook: /NationalLibraryofScotland

From: crarugal @.> Sent: 19 May 2022 15:34 To: ukwa/w3act @.> Cc: MacGlone, Eilidh @.>; Mention @.> Subject: Re: [ukwa/w3act] Test permission email is not arriving (Issue #674)

External Email: This email originated from outside of the National Library of Scotland. Do not click links or open attachments unless you have verified the sender and know the content is safe.

I think this could be down to the release process.

When I release the licences, I press send in the queued view: https://www.webarchive.org.uk/act/crawlpermissions/list?s=updatedAt&organisation=1 [image]https://user-images.githubusercontent.com/18530934/169317656-a4f7dc89-b0dc-4994-a744-b5f997fbbea7.png

Once sent, the 27 queued licences should be sent out, and their status is automatically changed to pending. [image]https://user-images.githubusercontent.com/18530934/169318024-482ea82c-0a2a-43a6-b901-403517b40b18.png

Sending an NLS licence in the queued status does work: [image]https://user-images.githubusercontent.com/18530934/169321199-3bc0ea21-29c1-4674-ba9c-134e333bd324.png

However, if you go into a queued licence, and manually change a licence from queued to pending, then the system doesn't email out the licence to the recipient: [image]https://user-images.githubusercontent.com/18530934/169318442-0240d6b0-4dea-4c27-a6f5-dacf9b67945a.png

So if I go to this test target, with a pending licence: https://www.webarchive.org.uk/act/crawlpermissions/51714 [image]https://user-images.githubusercontent.com/18530934/169319424-b9b66b0e-6199-41f2-9742-190669f6c7de.png and then press send, nothing will happen as the system thinks this licence has already been sent, and is awaiting for it to be granted of rejected by the recipient

Pressing send on a pending licence does take you back to the crawl permissions landing page, but the licence will not be emailed out. [image]https://user-images.githubusercontent.com/18530934/169320626-03acba28-4e5d-4fac-bf07-026c8bbced10.png

— Reply to this email directly, view it on GitHubhttps://github.com/ukwa/w3act/issues/674#issuecomment-1131786474, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADHNQMBY6JOOFNNRBZ3XNADVKZGPLANCNFSM5WBPWH4Q. You are receiving this because you were mentioned.Message ID: @.***>

National Library of Scotland, Scottish Charity, No: SCO11086

Our reading rooms, exhibitions, caf� and shop are open. Visit our website to join the Library or pre-order material.

This communication is intended for the addressee(s) only. If you are not the addressee please inform the sender and delete the email from your system. The statements and opinions expressed in this message are those of the author and do not necessarily reflect those of National Library of Scotland. This message is subject to the Freedom of Information (Scotland) Act 2002 and data protection legislation. Personal data sent to the Library by email will be processed in accordance with the Library�s privacy information available at www.nls.uk/privacy. No liability is accepted for any harm that may be caused to your systems or data by this message. If this communication relates to a request for information from the Library under the Freedom of Information (Scotland) Act 2002 (FOISA) and you are dissatisfied with our response, you may ask the Library to conduct a review of our decision(s) regarding the supply of information. To begin a review please contact us in writing or other recorded form and describe the original request, explain your dissatisfaction, and provide an address for correspondence. You have 40 working days from receipt of our response to your request to submit a request for review. We will respond within 20 working days of receipt of your request. If you are still dissatisfied after a review you may ask the Scottish Information Commissioner to intervene. You may launch an appeal with the Commissioner online at: www.itspublicknowledge.info/Appeal. For more information about FOISA please visit: www.itspublicknowledge.info.

Before you print please think about the ENVIRONMENT

anjackson commented 2 years ago

Oh dear, this seems to be a very serious error/bug in the user interface.

There are two buttons labelled 'Send'. One is on the Crawl Permissions list page:

2022-05-20-w3act-working-send-button

The other is on the individual Crawl Permission view page:

2022-05-20-w3act-broken-send-button

The code behind this latter button is here:

https://github.com/ukwa/w3act/blob/6d9ca6e7706382ccbc85b338ac356abd98cebfe4/app/views/crawlpermissions/view.scala.html#L223

The second button, the one on each individual crawl permission, does not send emails. It only takes you back to the list interface where emails can be sent in bulk.

As I remember, this was the intended workflow, but this means the button label is totally wrong and misleading, and should say something like 'Go to the Crawl Permissions list'. Note that hovering over the button shows the legend 'Go to the email queue', which is also wrong.

Having an actual Send button there that actually worked seems like a good idea, but I'm not yet sure how easy it will be to change that. The first button offers the ability to select a mail template, and I'm not quite sure how this relates to the 'Permission request template' and 'Acknowledgement template'.

crarugal commented 2 years ago

It's been an issue for a long time, I always assumed it was just one of the low priority quirks, which is why I've only ever released the licences in the crawl permission list and not through the individual crawl permission page.

anjackson commented 2 years ago

Based on internal conversations, I'm currently proposing that we deal with this issue by re-labelling the button so it says what it does, and otherwise leave things as they are.

nicolabingham commented 2 years ago

Thanks @anjackson I agree we should re-label this. Carlos and I are looking at the legacy permissions with Eilidh in the meantime.

emacglone commented 1 year ago

That could explain it. Was the issue just that I was making an unnecessary change? I’m a bit worried, I’m not sure when I started doing it that way!

I have sent myself a test email from QUEUED, I’ll let you know if I get it.

Eilidh

Eilidh MacGlone Web Archivist | Collections Management

National Library of Scotland 92 Cowgate, Edinburgh EH1 1JN Tel: +44 0131 623 3934 Email: @.**@.> Website: www.nls.ukhttp://www.nls.uk/ @.*** Facebook: /NationalLibraryofScotland

From: crarugal @.> Sent: 19 May 2022 15:34 To: ukwa/w3act @.> Cc: MacGlone, Eilidh @.>; Mention @.> Subject: Re: [ukwa/w3act] Test permission email is not arriving (Issue #674)

External Email: This email originated from outside of the National Library of Scotland. Do not click links or open attachments unless you have verified the sender and know the content is safe.

I think this could be down to the release process.

When I release the licences, I press send in the queued view: https://www.webarchive.org.uk/act/crawlpermissions/list?s=updatedAt&organisation=1 [image]https://user-images.githubusercontent.com/18530934/169317656-a4f7dc89-b0dc-4994-a744-b5f997fbbea7.png

Once sent, the 27 queued licences should be sent out, and their status is automatically changed to pending. [image]https://user-images.githubusercontent.com/18530934/169318024-482ea82c-0a2a-43a6-b901-403517b40b18.png

Sending an NLS licence in the queued status does work: [image]https://user-images.githubusercontent.com/18530934/169321199-3bc0ea21-29c1-4674-ba9c-134e333bd324.png

However, if you go into a queued licence, and manually change a licence from queued to pending, then the system doesn't email out the licence to the recipient: [image]https://user-images.githubusercontent.com/18530934/169318442-0240d6b0-4dea-4c27-a6f5-dacf9b67945a.png

So if I go to this test target, with a pending licence: https://www.webarchive.org.uk/act/crawlpermissions/51714 [image]https://user-images.githubusercontent.com/18530934/169319424-b9b66b0e-6199-41f2-9742-190669f6c7de.png and then press send, nothing will happen as the system thinks this licence has already been sent, and is awaiting for it to be granted of rejected by the recipient

Pressing send on a pending licence does take you back to the crawl permissions landing page, but the licence will not be emailed out. [image]https://user-images.githubusercontent.com/18530934/169320626-03acba28-4e5d-4fac-bf07-026c8bbced10.png

— Reply to this email directly, view it on GitHubhttps://github.com/ukwa/w3act/issues/674#issuecomment-1131786474, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADHNQMBY6JOOFNNRBZ3XNADVKZGPLANCNFSM5WBPWH4Q. You are receiving this because you were mentioned.Message ID: @.***>

National Library of Scotland, Scottish Charity, No: SCO11086

Our reading rooms, exhibitions, caf� and shop are open. Visit our website to join the Library or pre-order material.

This communication is intended for the addressee(s) only. If you are not the addressee please inform the sender and delete the email from your system. The statements and opinions expressed in this message are those of the author and do not necessarily reflect those of National Library of Scotland. This message is subject to the Freedom of Information (Scotland) Act 2002 and data protection legislation. Personal data sent to the Library by email will be processed in accordance with the Library�s privacy information available at www.nls.uk/privacy. No liability is accepted for any harm that may be caused to your systems or data by this message. If this communication relates to a request for information from the Library under the Freedom of Information (Scotland) Act 2002 (FOISA) and you are dissatisfied with our response, you may ask the Library to conduct a review of our decision(s) regarding the supply of information. To begin a review please contact us in writing or other recorded form and describe the original request, explain your dissatisfaction, and provide an address for correspondence. You have 40 working days from receipt of our response to your request to submit a request for review. We will respond within 20 working days of receipt of your request. If you are still dissatisfied after a review you may ask the Scottish Information Commissioner to intervene. You may launch an appeal with the Commissioner online at: www.itspublicknowledge.info/Appeal. For more information about FOISA please visit: www.itspublicknowledge.info.

Before you print please think about the ENVIRONMENT