search

ukwa / webarchive-discovery

WARC and ARC indexing and discovery tools.
https://github.com/ukwa/webarchive-discovery/wiki
117 stars 25 forks source link

Resource Name facets don't work; we need indexed=true. #170

Closed ruebot closed 6 years ago

ruebot commented 6 years ago

Fix a mistake from #146. :disappointed:

anjackson commented 6 years ago

As this is a small change that is now in conflict, I'll fix this via a separate change.

anjackson commented 6 years ago

Okay, so the schema has changed a bit since this PR. resourcename_facet is now indexed="true" and stored="false" but docValues="true".

Which I think means we're all good now. /cc @tokee

ruebot commented 6 years ago

multiValued="false" as well.

anjackson commented 6 years ago

Yes, current version says multiValued="false". All good?

https://github.com/ukwa/webarchive-discovery/blob/924545a41df6360da7ccad4e4aca8e78dbcbe96b/warc-indexer/src/main/solr/solr/discovery/conf/schema.xml#L111

ruebot commented 6 years ago

@anjackson, good. Want me to close this PR now?

anjackson commented 6 years ago

Yes please, if you're happy to.

ruebot commented 6 years ago

Thanks @anjackson!