search

uky-web-archive / seeblue

A University Drupal theme
1 stars 1 forks source link

Support SVG for logo images #6

Open ashooner opened 10 years ago

ashooner commented 10 years ago

Allow SVG to be used for the logo images to better accommodate scaling, high dpi displays, etc. Provide a raster fallback option.

cornettims commented 10 years ago

Are you imagining an SVG upload + Jpeg/PNG upload, or using one of the advanced imagecache modules to convert SVG to PNG (last time we looked at SVG + imagecache advanced, it.. wasn't good..)

ashooner commented 10 years ago

I would think just an upload for each would be simple and sufficient. This is not a priority vs. the bugs, by the way.

On Thu, Oct 17, 2013 at 11:28 AM, cornettims notifications@github.comwrote:

Are you imagining an SVG upload + Jpeg/PNG upload, or using one of the advanced imagecache modules to convert SVG to PNG (last time we looked at SVG + imagecache advanced, it.. wasn't good..)

— Reply to this email directly or view it on GitHubhttps://github.com/UK-PR/seeblue/issues/6#issuecomment-26517224 .

ashooner commented 10 years ago

Nice little article about this: http://tavendo.com/blog/post/falling-back-to-png/

petervcook commented 10 years ago

Thanks Andy. Do you think it is worth the extra JavaScript weight? If our main goal is support for hiDPI monitors and phones, I wonder if a more universal solution would be to ask the Content Admin to upload a PNG that is twice as big as needed for low DPI screen, and then just output that to the user, or use media queries to show the hiDPI version to users with screens that support it.

Because we are talking about the logo in this case, I am a little more hesitant to implement a cutting edge solution for the logo. If it was a small piece of content and it didn't appear as expected for 3% of visitors it may not be a big deal, but the logo is one of the most important pieces from a branding standpoint.