ulab-uiuc / research-town

A platform for developers to simulate research community
http://app.auto-research.dev
Apache License 2.0
84 stars 7 forks source link

feat(db): refactor db to support redis #783

Closed shreypandey closed 6 days ago

shreypandey commented 2 weeks ago

Closes #782

📑 Description

✅ Checks

ℹ Additional Information

shreypandey commented 2 weeks ago

Hi @lwaekfjlk , I have created this PR for refactoring code for database clients as discussed in #428. This adds the abstract class for database client, which can be extended by other clients such as redis in subsequent PRs.

Please review this PR once and let me know your thoughts on this.

lwaekfjlk commented 2 weeks ago

thanks, I will check later today

shreypandey commented 1 week ago

Hi @lwaekfjlk , I have updated the documentation to run the code. Please review the updated README.md for that.

lwaekfjlk commented 1 week ago

@shreypandey wow, your PR is amazing! Let's work together on more things!

lwaekfjlk commented 1 week ago

I just leave some little comments, generally looks amazingly good to me.

shreypandey commented 1 week ago

@shreypandey wow, your PR is amazing! Let's work together on more things!

Sure @lwaekfjlk ! Would love to work on more things!

shreypandey commented 1 week ago

Converting this to draft as waiting for #785 to merge. I will resolve the conflicts post merging #785 and reopen this.

lwaekfjlk commented 1 week ago

@shreypandey thanks for your efforts, I merged #785

shreypandey commented 1 week ago

Hi @lwaekfjlk, I have resolved the conflicts and reopened the PR. Please review the PR and let me know your thoughts on this. The PR is ready to merge now.

I have tested the code by running the test cases, examples and demo.

lwaekfjlk commented 1 week ago

sure. This is a big PR so I need to take some time and confirm on my side everything in bench works as well.

shreypandey commented 1 week ago

Sure @lwaekfjlk! Let me know your feedback and incase of any issues.