Closed shreypandey closed 6 days ago
Hi @lwaekfjlk , I have created this PR for refactoring code for database clients as discussed in #428. This adds the abstract class for database client, which can be extended by other clients such as redis in subsequent PRs.
Please review this PR once and let me know your thoughts on this.
thanks, I will check later today
Hi @lwaekfjlk ,
I have updated the documentation to run the code. Please review the updated README.md
for that.
@shreypandey wow, your PR is amazing! Let's work together on more things!
I just leave some little comments, generally looks amazingly good to me.
@shreypandey wow, your PR is amazing! Let's work together on more things!
Sure @lwaekfjlk ! Would love to work on more things!
Converting this to draft as waiting for #785 to merge. I will resolve the conflicts post merging #785 and reopen this.
@shreypandey thanks for your efforts, I merged #785
Hi @lwaekfjlk, I have resolved the conflicts and reopened the PR. Please review the PR and let me know your thoughts on this. The PR is ready to merge now.
I have tested the code by running the test cases, examples and demo.
sure. This is a big PR so I need to take some time and confirm on my side everything in bench works as well.
Sure @lwaekfjlk! Let me know your feedback and incase of any issues.
Closes #782
📑 Description
✅ Checks
type/descript
(e.g.feature/add-llm-agents
)ℹ Additional Information